[patch] kdm background to all screens

Petri Damstén petri.damsten at gmail.com
Thu Sep 4 12:50:54 BST 2008


On Thursday 04 September 2008 12:50:45 Oswald Buddenhagen wrote:
> unless you don't want to do that yourself, i'd prefer a separate patch
> for doing that right going in first. as is, your patch now introduces
> dummy code, which i don't particularly like. if you want to be lazy,
> just hard-code the screen 0 for now, without any variable.

Seems that FDialog already takes care of greeter screen for other than the 
background so I just used _greeterScreen and it seems to work.

> > +++ kfrontend/themer/kdmitem.h	(working copy)
> > +	QString paintOnScreen;
>
> that's inefficient. the property should be converted into an enum value
> upon parsing the theme.

It's now enum.

Petri

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdm_background2all_screens.diff
Type: text/x-patch
Size: 5251 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080904/f11683b3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080904/f11683b3/attachment.sig>


More information about the kde-core-devel mailing list