[PATCH] CapsLock check

Alessandro Diaferia alediaferia at gmail.com
Tue Sep 2 19:39:54 BST 2008

2008/9/2 Olivier Goffart <ogoffart at kde.org>

> Le lundi 1 septembre 2008, Alessandro Diaferia a écrit :
> > Ok, here comes the patch, even if it is almos the same as before =)
> > Please try this.
> the bool KPasswordDialog::KPasswordDialogPrivate::isCapsLockToggled()
> will return an undefined value if Q_WS_X11 is not defined...  bad

right! I added a return false outside the #ifdef =)

> Also, i think it may be safer to check if we have a keyEvent in the
> eventFilter.
> Otherwise there is a risk of infinite loop if ever the capsWarning function
> trigger an event.  (which is not impossible considered what it does)

Sure, fixed!

> --
> Olivier

Unfortunately kdesu still doesn't make use of this eventFilter :(

Alessandro Diaferia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080902/d38fdcda/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: capschecker.diff
Type: application/octet-stream
Size: 3283 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080902/d38fdcda/attachment.obj>

More information about the kde-core-devel mailing list