[PATCH] CapsLock check

Olivier Goffart ogoffart at kde.org
Tue Sep 2 18:29:53 BST 2008


Le lundi 1 septembre 2008, Alessandro Diaferia a écrit :
> Ok, here comes the patch, even if it is almos the same as before =)
> Please try this.

the bool KPasswordDialog::KPasswordDialogPrivate::isCapsLockToggled()
will return an undefined value if Q_WS_X11 is not defined...  bad

Also, i think it may be safer to check if we have a keyEvent in the 
eventFilter.
Otherwise there is a risk of infinite loop if ever the capsWarning function 
trigger an event.  (which is not impossible considered what it does)

-- 
Olivier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080902/c9f1c012/attachment.sig>


More information about the kde-core-devel mailing list