Trunk build problems

[Alexander Neundorf]

On Saturday 11 October 2008, Hasso Tepper wrote:
> Adriaan de Groot wrote:
> > On Friday 10 October 2008 13:05:58 Hasso Tepper wrote:
...
> > > CMake Error at phonon/cmake/FindGLIB2.cmake:28
> > > (get_filename_component): get_filename_component unknown component
> > > intl
> >
> > My first guess, not necessarily accurate, is too-old CMake version not
> > checked in phonon's cmakelists.
>
> Cmake is 2.6.1, it shouln't be too old ;). It is this commit -
> http://lists.kde.org/?l=kde-commits&m=121932798303515&w=2
>
> My first guess was too agressive developer ;) - it just doesn't make sense
> to call get_filename_component() on this:
>
> $ pkg-config --libs glib-2.0
> -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lglib-2.0 -lintl

Yes, this is wrong.

> But my second guess is that this get_filename_component() should be just
> removed, I don't see the result used anywhere.

Sounds good.

> > > * libdl.so doesn't exist in every platform (only in Linux and
> > > Solaris?), but it is used unconditionally in some places in the
> > > kdebase. The

That's clearly a bug.

> > Shouldn't be used unconditionally. Since FreeBSD 6 & 7 are supported
> > platforms and they don't have libdl.so either, this is already fixed
> > *somewhere*.
>
> Yes, I actually copied it from *somewhere* :).

So is it fixed in svn now ?

Alex