[PATCH] Removing unnecessary friend declarations from kcolordialog.h

Albert Astals Cid aacid at kde.org
Sun Oct 5 14:30:39 BST 2008

A Diumenge 05 Octubre 2008, Christoph Bartoschek va escriure:
> Am Sonntag 05 Oktober 2008 schrieb Thiago Macieira:
> > Christoph Bartoschek wrote:
> > >This means that there is no need to make nested classes friend. Although
> > > this is the text of the comming standard any decent compiler should
> > > support this and at least GCC does.
> >
> > That's the upcoming standard. We can expect to start using it around
> > 2011, assuming it is published next year.
> >
> > For existing compilers, we have to follow the rules of C++98.
> Yes, but here remains point one valid. For me it does not matter what you
> do - removing the friend declarations or fixing them - as long as the code
> starts do compile with an EDG based compiler. In my opinion it is better to
> remove them because the privileges are not used.

I've removed second and third that were wrong, first is not wrong, so i see no 
reason to remove it.


> Christoph

More information about the kde-core-devel mailing list