Let kquitapp fail verbosely

[Ingo Klöcker]

On Sunday 25 May 2008, Stefan Monov wrote:
> Hi, thanks for the comments. :)
>
> > Since KDE includes are already present I'd use kError() or
> > kWarning() (not kDebug() either way).
>
> kWarning() outputs:
> kquitapp(4511)/ main: "foo: no application quit"
> Quite ugly and debuggish. At least, the function "main" and the
> quotation marks shouldn't be there. Is kWarning() really intended for
> use with command line tools?
>
> > Also in theory people can have a notification pop up
> > for these types of events if there's not running kquitapp from the
> > shell.
>
> But this popup would be annoying if I actually worked in the shell,
> and I don't think kquitapp is told who launched it.
>
> I attached the current patch for reference.

I suggest to exit with a non-zero exit code if quitting failed.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080525/539a3144/attachment.sig>