Let kquitapp fail verbosely

Thiago Macieira thiago at kde.org
Sun May 25 00:55:55 BST 2008

Stefan Monov wrote:
>Currently, when kquitapp fails to do its job, it says nothing, which
>can be confusing. Attached is a patch that makes it output an error
>message instead (modeled after killall's).
>I was unsure whether to use fputs, fprintf, cerr or kDebug() (all of
>those are used throughout KDE), so I picked what's nicest - cerr. ;)
>Also I'm unsure whether the toLocal8bit conversion is needed.
>Can I commit?

Suggestion: print any errors that may result, not just ServiceUnknown.

Also, "quit" is preferrable instead of "quitted".

  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080525/9d4ba8d0/attachment.sig>

More information about the kde-core-devel mailing list