Goya and KRichText

[Simon Hausmann]

On Sunday 11 May 2008 23:39:22 Allen Winter wrote:
> Howdy,
>
> Toma and I think that Friday 16 May would be a nice time
> to move Goya and KRichText from kdereview into kdelibs.
>
> Unless there are objections to these libs, of course.
>
> This gives us 10 days of review, plus a few days before
> the hard feature freeze and the beta1 tagging.
>
> So.. please give a look to these goodies in kdereview
> in the next few days if you have some time.

Four small comments:

1) Is it intentional that KRichTextEdit has a public QString fileName member 
variable?

2) In KRichTextEdit many of the slots have a 'slot' prefix in their method 
name. I suggest to remove it, it's redundant.

3) I suggest to merge at least KRichTextWidget and KRichTextEditor into one 
class.

4) I suggest to remove 'NestedListHelper' from the public API.


Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080513/9bd71104/attachment.sig>