KIO fixes in kdelibs and kdebase

[Thiago Macieira]

On Friday 09 May 2008 05:28:04 Vlad wrote:
> Sure! If KDE apps are compiled without the -D_FILE_OFFSET_BITS=64 and
> -D_LARGEFILE64_SOURCE flags, KDE apps will not be able to correctly
> pass variables of type off_t to libraries that are compiled with those
> flags, such as libsmbclient. For example, if kio_smb is not compiled
> with -D_FILE_OFFSET_BITS=64 and -D_LARGEFILE64_SOURCE, the smbc_lseek
> function moves the cursor to a different position than was requested.

In other words: it's bad practice to write public API that uses off_t. In C++ 
it'll cause linkage errors (missing symbols) and in C it'll cause mysterious 
behaviour and possibly crashes.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080509/91a42d7a/attachment.sig>