KIO fixes in kdelibs and kdebase

[Vlad]

Hi,

--- Oswald Buddenhagen <ossi at kde.org> wrote:
> On Tue, May 06, 2008 at 06:35:27PM -0700, Vlad Codrea wrote:
> > - Compile kdelibs with -D_LARGE_FILES instead of
> > -D_LARGEFILE64_SOURCE, and drop the redundant
> -D_LARGEFILE64_SOURCE
> > flag in kio.
> > 
> > - Compile kdebase with -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE64_SOURCE to
> > support large files.
> > 
> you certainly want to give a rationale for the different treatment. 
> :-)

Sure! If KDE apps are compiled without the -D_FILE_OFFSET_BITS=64 and
-D_LARGEFILE64_SOURCE flags, KDE apps will not be able to correctly
pass variables of type off_t to libraries that are compiled with those
flags, such as libsmbclient. For example, if kio_smb is not compiled
with -D_FILE_OFFSET_BITS=64 and -D_LARGEFILE64_SOURCE, the smbc_lseek
function moves the cursor to a different position than was requested.

Vlad


      ____________________________________________________________________________________
Be a better friend, newshound, and 
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ