[PATCH] Fix KLineEdit::rotateText to actually complete.
faure at kde.org
Wed May 7 11:42:45 BST 2008
On Tuesday 06 May 2008, Allen Winter wrote:
> On Friday 18 April 2008 13:24:55 Kelvie Wong wrote:
> > Because input is never set, the skip rotation condition is always true.
> > This seemed to be broken by r231422 (from 2003), which changed it from a
> > ternary expression to an "if" statement.
> > Not sure if it's used anywhere though, but it seems like a bug.
> Does seem like a bug.
> Should we commit this?
> > ---
> > kdeui/widgets/klineedit.cpp | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> > diff --git a/kdeui/widgets/klineedit.cpp b/kdeui/widgets/klineedit.cpp
> > index 05fa31d..0b7ce03 100644
> > --- a/kdeui/widgets/klineedit.cpp
> > +++ b/kdeui/widgets/klineedit.cpp
> > @@ -383,9 +383,9 @@ void KLineEdit::rotateText(
> > KCompletionBase::KeyBindingType type ) QString input;
> > if (type == KCompletionBase::PrevCompletionMatch)
> > - comp->previousMatch();
> > + input = comp->previousMatch();
> > else
> > - comp->nextMatch();
> > + input = comp->nextMatch();
Indeed this is a bug -- which is in KDE3 too. I'll make the change.
Thanks for the note and investigation.
We didn't see this before because I think not many people use the "rotate between completions" feature.
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel