[patch] KToolInvocation: re-enable Windows code, share with UNIX, add invokeTerminal()

Jarosław Staniek js at iidea.pl
Fri Mar 28 11:09:17 GMT 2008

For review.

1. The following methods are identical on all platforms and thus would be good 
to  move them to the common ktoolinvocation.cpp file.
- KToolInvocation::invokeHelp()
    identical (except and ifdef for problem with startServiceByDesktopName())
- KToolInvocation::invokeMailer() - identical
- KToolInvocation::startKdeinit() - identical except additional --suicide arg 
for UNIX

2. Reneable code that was used in KDE3/win32 (and now runs fine too)
- void KToolInvocation::invokeMailer(const QString &_to, const QString &_cc,
				  const QString &_bcc,
                                  const QString &subject, const QString &body,
                                  const QString & /*messageFile 
TODO*/, const 					 QStringList &attachURLs,
                                  const QByteArray& startup_id )
- void KToolInvocation::invokeBrowser( const QString &url, const QByteArray& 
startup_id )

Both methods use ShellExecute().

3. BTW, add Aaron's most recent KToolInvocation::invokeTerminal() for invoking 
the standard terminal application.
(TODO on Windows, will probably run cmd.exe by default)

regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ktoolinvocation.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080328/e695e733/attachment.ksh>

More information about the kde-core-devel mailing list