[PATCH] KFilePlacesModel : separate storage for custom items and standard items

Kevin Ottens ervin at kde.org
Wed Mar 26 18:34:25 GMT 2008

Le Sunday 16 March 2008, nf2 a écrit :
> The new approach keeps the ~/.kde4/share/apps/kfileplaces/bookmarks.xml
> as it was and synchronizes the custom items with
> .local/share/shortcuts.xbel. The Synchronization is done by the new
> class KFilePlacesSharedBookmarks.

It looks fine here. I'd only have one complaint about this one, it blindly 
copies the whole bookmark to .local/share/shortcuts.xbel, while it should 
probably avoid copying all the KFilePlacesModel specific metadata (like ID, 
isSystemItem, etc.). Could you try to tidy that up before committing?

Testing your patch I noticed that now the default places have wrong icons... 
Actually after reverting I still see this behavior, so I wonder if it could 
be related to your previous changes to KBookmark.

> The minor changes to KFilePlacesModel:
> * System items are tagged with a <isSystemItem>true</isSystemItem>.
> * I improved the ID-generator for more unique id's.

They look fine.

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080326/1c91ffa2/attachment.sig>

More information about the kde-core-devel mailing list