[patches to kdelibs/base] request for comment

Thiago Macieira thiago at kde.org
Fri Mar 21 18:50:56 GMT 2008

Marcel Partap wrote:
>+bool KUrl::hasSubDomain() const
>+  return host().count(QLatin1Char('.')) > 1 );

Sorry, but the above is wrong.

"estadao.com.br" has no subdomain, yet the function would return true.

Like I said, this belongs in the web browser. There are rules for sub 
domains like that already in the cookie management code.

  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080321/a7da27f2/attachment.sig>

More information about the kde-core-devel mailing list