[Patch] System Settings : Improve General/Advanced tabs visibility

Peter Penz peter.penz at gmx.at
Thu Mar 20 15:27:02 GMT 2008


> Hi,
> 
> The patch has been commited, without adding icon in the tab bar.
> 
> http://stuff.forum-software.org/kde/system-settings-before.png
> http://stuff.forum-software.org/kde/system-settings-after.png
> 
> We would like to have the artists and usability opinion about adding
> or not the icons (in the after.png screenshot) in the tab bar, of
> course, different from the currently selected in the screenshot.

One additional question for the Oxygen team: As far as I've seen it has not been discussed yet whether removing the tab-content-frame in "after" is an improvement to the "before" state.

With the current implementation of the Oxygen style removing the tab-content-frame leads to an optical issue regarding the sunken/raised borders:

- The tab content (= white area) is sunken one level below the window level.

- The active tab (= "General") is raised one level above the window level. But on the right side of the tabs the separator just flows into the window level content, which is not possible. Also the the bottom-left border of the active tab contains a small hole that indicates that the tab is on the same level as the window.

If an Oxygen artist would send me a screenshot how a frame-less tab should look like, I would fix this in the Oxygen style (for sure I'd ask Casper Boemann before committing anything).

Anyhow I just wanted to add this point here, as the optical issue bothers me since quite a long time in the Konsole window already ;-)

Peter

> On Thu, Mar 20, 2008 at 9:31 AM, Nicolas Ternisien
> <nicolas.ternisien at gmail.com> wrote:
> > So ? Do I remove the icon from the patch, then you apply it, and at
> >  the same time we ask the opinion of artists and usability ?
> >
> >
> >
> >  On Thu, Mar 20, 2008 at 3:29 AM, Torsten Rahn
> <torsten.rahn at credativ.de> wrote:
> >  >
> >  > On Wednesday 19 March 2008 18:16:57 Will Stephenson wrote:
> >  >  > On Wednesday 19 March 2008, Nicolas Ternisien said:
> >  >  > > Here is a little improvement of the patch, with a full size tab
> >  >  > > support (and the fix of a forgotten emitted signal)
> >  >  >
> >  >  > Looks great, and the patch does too.  I'd say commit it.
> >  >
> >  >  I'd say that this still needs to get approved by the usability and
> by the
> >  >  oxygen people.
> >  >
> >  >  Torsten
> >  >
> >  >  > Will
> >  >
> >  >
> >  >
> >  >  --
> >  >   Torsten Rahn
> >  >
> >  >   Tel.: 0 21 61 - 46 43 - 192
> >  >
> >  >  credativ GmbH, HRB Mönchengladbach 12080
> >  >  Hohenzollernstr. 133, 41061 Mönchengladbach
> >  >  Geschäftsführung: Dr. Michael Meskes, Jörg Folz
> >  >
> >




More information about the kde-core-devel mailing list