[PATCH] KActionCollection: Deprecate actionHighlighted() and rename it actionHovered()

Nicolas Ternisien nicolas.ternisien at gmail.com
Mon Mar 10 09:55:03 GMT 2008


Hi,

I've just done a little patch on KActionCollection, which deprecate
actionHighlighted() and rename it actionHovered(), to match the
QAction API. This patch is linked to my previous and never answered
email attached here.

That's my first KDEcore patch, so be cool with it ;-)

Regards.



>
>
>  On Sat, Feb 23, 2008 at 6:20 PM, Nicolas Ternisien
>  <nicolas.ternisien at gmail.com> wrote:
>  > Hi,
>  >
>  >  The signal actionHighlighted(QAction* ) in KActionCollection does not
>  >  work and generate some error output :
>  >
>  >  ----------------------
>  >  ....
>  >  Object::connect: No such signal KAction::highlighted()
>  >  Object::connect:  (sender name:   'switch_application_language')
>  >  Object::connect:  (receiver name: 'KXMLGUIClient-KActionCollection')
>  >  Object::connect: No such signal KAction::highlighted()
>  >  Object::connect:  (sender name:   'help_about_app')
>  >  Object::connect:  (receiver name: 'KXMLGUIClient-KActionCollection')
>  >  Object::connect: No such signal KAction::highlighted()
>  >  Object::connect:  (sender name:   'help_about_kde')
>  >  Object::connect:  (receiver name: 'KXMLGUIClient-KActionCollection')
>  >  ----------------------
>  >
>  >  This is due to the use of the highlighted() signal in connectNotify()
>  >  for a QAction* instance :
>  >
>  >  http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKActionCollection.html#5125866fe10167dada4d1765e552cfce
>  >
>  >  I think the signal that should be used could be hovered() in QAction,
>  >  but it will also need to rename the actionHighlighted(QAction* )
>  >  signal into actionHovered(QAction* )
>  >
>  >  Regards.
>  >
>  >  Nicolas Ternisien
>  >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kactioncollection-signal-hovered-renamed.patch
Type: text/x-diff
Size: 2963 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080310/5320ff6c/attachment.patch>


More information about the kde-core-devel mailing list