[patch] KLocale: minor optimization + use safer qgetenv

Jarosław Staniek js at iidea.pl
Thu Mar 6 11:50:06 GMT 2008

For review.
- Minor optimization: before we've typically iterated twice (in 
initLanguageList() and setLanguage() over lost of (typically) empty strings.
- Use safer qgetenv, based on getenv_s under msvc>=2k5 and just ::getenv 

I shall also propose more changes to qgetenv (and qputenv), especially in 
places where we cast to QByteArray or QString.

regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: klocale-getenv.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080306/bcf3c9ae/attachment.ksh>

More information about the kde-core-devel mailing list