[QK]ComboBox::setEditIcon? (Re: [PATCH] Re: More responsible KFileWidget)

David Faure faure at kde.org
Wed Jun 25 21:24:24 BST 2008

On Saturday 21 June 2008, Rafael Fernández López wrote:
> Hi,
> This patch works in all cases and from my point of view is far more correct 
> than the other one.
> I still have to write the support for 'loading icons when autocompletion has 
> been done'.

I dislike dummy items hacks. I can see how qcombobox doesn't offer any other way
to set the icon when setting also the edit-text (setEditText)... but maybe that's where
the problem really is. I would 1) request a setEditIcon to Trolltech, and 2) consider
adding this feature in kcombobox if TT says no [or takes too long], to avoid having to
duplicate this hacks in more than one place. Yes it would still be a dummy item hack,
but hopefully hidden behind a nice API :-)  -- and easier to unit test.

IIRC there are dummy-item hacks in KonqCombo... ah yes, KonqCombo::setTemporary.
Hmm OK there's more complexity there, with the support for showing page titles etc.
OK, so forget konq, but otherwise (question for everyone) -- do we have other KDE
apps where a [QK]ComboBox::setEditIcon would simplify the code greatly?

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list