[PATCH] [SCREENIES] Improvements to kio_man
Michael Pyne
mpyne at purinchu.net
Thu Jun 19 23:02:17 BST 2008
On Thursday 19 June 2008, Urs Wolfer wrote:
> On Thursday 19 June 2008 01:25:27 Michael Pyne wrote:
> > I've made a patch that fixes it and makes it look better (at least, IMO).
> > Both the headers and footers are corrected and somewhat more employed.
> > I've tried to make the appearance more like www.kde.org as well.
>
> Good work. I just would like to have the same style as all the others apps
> with "HTML"-pages does have (e.g. all the start pages, see my other mail in
> this thread). It would be a pitty to just have a different style here.
> Either update all (please talk to the oxygen artists first), or try to
> follow the current look.
I think the objection to the Konq page is because of the off-white thin line
which you can see coming out to the right from the logo, extending under the
"Konqueror" text. It is the same color as the background of the descriptive
text but is not the same color as the background, which looks distracting.
In addition I really don't think the Konqueror/KMail example would apply to
the man page output, as the text would have to be artifically confined to the
black box which would make the output much longer than it otherwise has to be.
I chose the www.kde.org site because it is the current example of what KDE
uses to distribute lots of information over HTML (TechBase, for instance, has
much the same style), as opposed to using the same stuff used for the
Konqueror start page, as that seems intended to be more of a pretty "Hello!"
widget than a general purpose HTML presentation style sheet (indeed, the
components for that are in the "/about" directory of kdeui, implying that they
are a fancy About box).
> > I had to add a style sheet which I simply dumped into a header file, it
> > can't go straight into a installed css as it needs some munging to insert
> > the correct path to the doc/HTML directory.
>
> You could take the stylesheet which is installed from kdeui (see for
> example KMail or Konqueror) instead of copying this to a second place.
The problem comes because the image files required are pulled in from the CSS.
This could be rectified by simply appending the correct CSS style rules in the
generated HTML so that straight .css could be used, so I will rework the patch
to do that. But I still wouldn't be able to use the stylesheets from
kdeui/about.
Thanks for the suggestions though. If no one else has any objections in the
next few hours or so I'll probably go ahead and commit, we can integrate the
various styles later if we decide to go that route.
Regards,
- Michael Pyne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080619/f12afe63/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080619/f12afe63/attachment.sig>
More information about the kde-core-devel
mailing list