State of mmap for icon cache

[Thiago Macieira]

On Tuesday 17 June 2008 10:22:25 Andreas Pakulat wrote:
> Hi,
>
> I'd like to get a short overview of the current state of mmap support in
> our pixmap cache. Last I checked it was disabled due to bug #160284, did
> it get enabled again meanwhile?
>
> I just had a quick glance at kpixmapcache.cpp and it seems like it is
> enabled again. So could the fixes that have been done for the mmap'ing
> slow down icon loading that much? Because loading of icons has become
> quite slow in KDevelop, I notice it in our project tree which uses
> KIO::pixmapForUrl() or KIcon() constructor to load the icons. Another
> developer has serious problems with the code-completion, it seems that
> for him icons are read from disk over and over again (i.e. no caching at
> all as it seems). I don't know how recent his kdelibs is though, as I
> can't reproduce such a severe problem with the code-completion here
> (up-to-date kdelibs as of yesterday).

I've got a refactoring of the mmap code using QFile::map(). I didn't want to 
submit it while trunk is in feature freeze.

I'll submit when it's unfrozen.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080617/ba553bf8/attachment.sig>