Make KStyle honour KDE wide single-click behaviour

[Ingo Klöcker]

On Wednesday 11 June 2008, Andreas Pakulat wrote:
> On 11.06.08 00:34:29, Andreas Pakulat wrote:
> > On 10.06.08 23:44:37, Andreas Pakulat wrote:
> > > as I'm not sure its allowed for KDE styles (due to being loadable
> > > inside plain Qt apps) to use KGlobalSettings I'm posting for
> > > review.
> > >
> > > The attached patches makes KStyle provide the proper styleHint()
> > > for QStyle::SH_ItemView_ActivateItemOnSingleClick, which means
> > > reading the KDE wide setting for single vs. double click and
> > > returning that. I consider this a bugfix as currently any
> > > itemview emits the activated() signal only when double-clicking
> > > items - on all platforms, regardless of the kde-wide setting.
> >
> > Here's an updated one (which also compiles ;). Talked to David a
> > bit on IRC and he pointed out that using
> > KGlobalSettings::singleClick() is not a problem as long as I create
> > a kcomponentdata before that. So thats what I changed.
> >
> > Anybody has objections against this patch?
>
> Second try :)

How expensive is creating a new KComponentData? How expensive is 
KGlobalSettings::singleClick()? And how often is this style hint asked 
for, i.e. do the first two questions matter?


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080611/49195ff5/attachment.sig>