Fwd: KDirOperator patchlets

Andreas Pakulat apaku at gmx.de
Mon Jul 28 10:48:21 BST 2008


On 28.07.08 11:12:19, Carsten Pfeiffer wrote:
> Am Samstag, 26. Juli 2008 schrieb Peter Penz:
> > Ups, the patch has a sideeffect which I think we all missed: It is not
> > possible anymore selecting more than one file in e. g. Kate or KWrite.
> >
> > Reverting commit 836195 from the 4.1 branch brings back the original
> > functionality.  You write in your mail that included the patch:
> > "The second thing is that pressing return on the current item does not emit
> > fileSelected() but fileHighlighted(). I'm wondering if this was an accident
> > or done on purpose. See attached kdiroperator-fileSelected.patch."
> >
> > It seems like this has been done on purpose to make it possible selecting
> > more than one file. May I revert this patch on KDE 4.1 and trunk? Well it
> > will be too late for 4.1.0 I assume, but it's for sure no showstopper if
> > the fix will be in 4.1.1...
> 
> I assume that there are not many clients of KDirOperator besides KFileDialog 
> in KDE 4

Well, its currently used in Kate and KDevPlatform plugins. lxr.kde.org
shows usages in amarok, k3b, kile, kalva and kuickshow. So KFileDialog
is certainly not the only client, though still the one used most often I
guess.

Andreas

-- 
Time to be aggressive.  Go after a tattooed Virgo.




More information about the kde-core-devel mailing list