Fwd: KDirOperator patchlets

[Peter Penz]

On Saturday, 26. July 2008 21:07:28 Alexander Dymo wrote:
> On Saturday 26 July 2008 21:53:07 Peter Penz wrote:
> > It depends on how you do the multiple selection: if you use the
> > rubberband, the current solution still works. If you use CTRL+click, then
> > after the first click the file gets selected + the dialog gets closed (at
> > least on my system - updated kdelibs on trunk including Alexanders
> > patches). Rafael, can you let us know whether the multiple selection with
> > CTRL+click works in your environment?
>
> Ok, so ctrl-click's and shift-clicks shouldn't select files, but highlight
> them in single click mode, right?

Yes (at least this was the behavior in KDE 3.x and KDE 4.0).

> I'll take a look at that and try to fix 
> that today or tomorrow in trunk. But I don't know if you want my changes in
> 4.1 branch, it's probably too fresh/untested for 4.1.

On KDE 4.1 the only thing that is needed to get it work is to exchange one 
line of code:

Index: kfile/kdiroperator.cpp
===================================================================
--- kfile/kdiroperator.cpp	(Revision 838048)
+++ kfile/kdiroperator.cpp	(Arbeitskopie)
@@ -2028,7 +2028,7 @@
     if (selectDir) {
         parent->selectDir(item);
     } else {
-        parent->selectFile(item);
+        parent->highlightFile(item);
     }
 }

which means reverting svn commit 836195. I'm not sure whether backporting your 
changes from svn commit 838000 is a good idea, as the fixes are non-trivial 
and I think not enough tested yet to be sure that no side effects have been 
introduced.

I've not tested yet whether changing the one line is also sufficient on trunk, 
so it would be great if you can check whether the fix also works in 
combination with your cleanups from svn commit 838000.

Currently I'm mainly asking whether I can apply the patch above on the 4.1 
trunk (we have 6 months left on trunk to fix this in a nice way ;-)).

Thanks in advance!
Peter