Help with making stuff compile on non-Linux
Sebastian Trüg
strueg at mandriva.com
Thu Jul 24 08:05:25 BST 2008
On Wednesday 23 July 2008 22:10:21 Alex Merry wrote:
> On Wednesday 23 July 2008 09:15:06 Sebastian Trüg wrote:
> > Please find attached a version containing some ifdefs. Do you think I can
> > commit this or should I wait for Monday in case it breaks for some people
> > and needs fixing by the real experts. ;)
>
> I don't really see why you need to bother with the HAVE_* macros - why not
> just use #ifdef SCHED_BATCH and #ifdef SYS_ioprio_set directly?
>
> IMO, this make the code more readable, because it's immediately obvious
> what the #ifdefs guard against. The HAVE_* macros are really for CMake
> checks.
Only one reason: in case there is a fancier check one would only have to
replace it in one place.
Cheers,
Sebastian
More information about the kde-core-devel
mailing list