[Patch] Add two new tree-based modes to KDirOperator
kloecker at kde.org
Fri Jul 11 21:08:59 BST 2008
On Thursday 10 July 2008, Peter Penz wrote:
> On Thursday, 10. July 2008 16:27:40 Rafael Fernández López wrote:
> > Hi,
> > > Having tested this a bit, it works fine and I can't see any
> > > problems with the code itself. Peter, Rafael what do you think?
> > I have to say I haven't tested it, but the patch seems OK. This is
> > an OK from my side.
> +1 from my side (I also did not test it, but have checked the code)
I have no real knowledge of KDirOperator, so all I can give is a general
advise: Adding n different modes to a single class is not really good
design. I suggest to look into using the Strategy pattern.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 194 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel