[patch] Native "Open With" dialog on Windows

Jaroslaw Staniek js at iidea.pl
Thu Jul 10 14:12:56 BST 2008

David Faure said the following, On 2008-07-10 13:27:
> On Thursday 10 July 2008, Jaroslaw Staniek wrote:
>> (for review)
>> Native "Open With" dialog on Windows (by default).
>> This allows to use (and associate) given file extensions with any Windows 
>> application directly, as users expect.
>> - moved KRun::KRunPrivate declaration to krun_p.h
>> - added KRun::KRunPrivate::displayNativeOpenWithDialog() for Windows only
>>    in krun_win.cpp
>> - added a note to KOpenWithDialog that using KRun::displayOpenWithDialog()
>>    is recommended
> Why should this be in KRun? I think this is an odd place for the main displayOpenWithDialog() call.
> Can't it be a static method of KOpenWithDialog instead, just like we do for KFileDialog?

I wanted to ask this question, and have the same proposal, as I dislike the 
location too...
But it's in kdelibs already. I can make displayOpenWithDialog() obsolete and 
add KOpenWithDialog::openWith() or so.

regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)

More information about the kde-core-devel mailing list