[patch] Native "Open With" dialog on Windows

David Faure faure at kde.org
Thu Jul 10 12:27:51 BST 2008

On Thursday 10 July 2008, Jaroslaw Staniek wrote:
> (for review)
> Native "Open With" dialog on Windows (by default).
> This allows to use (and associate) given file extensions with any Windows 
> application directly, as users expect.
> - moved KRun::KRunPrivate declaration to krun_p.h
> - added KRun::KRunPrivate::displayNativeOpenWithDialog() for Windows only
>    in krun_win.cpp
> - added a note to KOpenWithDialog that using KRun::displayOpenWithDialog()
>    is recommended

Why should this be in KRun? I think this is an odd place for the main displayOpenWithDialog() call.
Can't it be a static method of KOpenWithDialog instead, just like we do for KFileDialog?

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list