[PATCH] Unbreak global shortcuts configuration

David Faure faure at kde.org
Wed Jan 30 20:57:25 GMT 2008

On Sunday 27 January 2008, Aurélien Gâteau wrote:
> # 1_{kdelibs,kdebase}_show_empty_actions.diff
> This patchset brings the empty actions (like KWin actions) back.
> To do so, I had to rework the way the kcm initialize itself: it used to ask
> KdedGlobalAccel for all available shortcuts, then for each shortcut get the
> action. Obviously this implementation couldn't get actions without
> shortcuts.
> My implementation ask KdedGlobalAccel for the list of components, then for
> the list of actions for each component. To do so it adds two methods to
> KdedGlobalAccel: allComponents() and allActionsForComponent(). I also had
> to remove all the "remove empty shortcuts" code from KdedGlobalAccel.
> # 2_{kdelibs,kdebase}_default_shortcuts.diff
> Previous patchset makes it possible to define shortcuts for all actions, but
> when you define a custom shortcut, close the kcm and open it again, your
> custom shortcut will appear as the default one.
> This second patchset makes KdedGlobalAccel aware of the concept of default
> and active shortcuts. It adds a new method: defaultShortcut(), which is
> used by the kcm to initialize the KAction correctly.

Thanks a lot for the patches, applied (to 4.0-branch; forwardport coming up).

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list