Suspicous code in KDE 4 trunk r764353

[Tobias Koenig]

On Tue, Jan 22, 2008 at 12:21:42AM +0100, Christoph Bartoschek wrote:
Hej,

> - kdepimlibs/syndication/dataretriever.cpp:211
> 
> d->process is NULL since line 209. Nice crash.
Fixed

> - kdepimlibs/kldap/ldapmodel_p.cpp:170
> 
> What if depth is 0 and item still NULL here?
Fixed

> - In the generated file
>   build/kdepimlibs/kabc/field.cpp:390,392
>   
> breaks are probably missing here.
Fixed

> - kdepimlibs/kcal/vcalformat.cpp:1452
> 
> fakeCString is deleted with deleteStr and not delete.
Fixed

> - kdepimlibs/kcal/scheduler.cpp:439
> 
> Line 434 indicates that ev might be NULL here.
Work in progress...

> - kdebase/apps/konqueror/sidebar/trees/dirtree_module/dirtree_item.cpp:170
>   kdebase/apps/konqueror/settings/filetypes/kservicelistwidget.cpp:442
>   kdegames/kpat/klondike.cpp:177
>   kdegames/libkdegames/highscore/kexthighscore_gui.cpp:501
>   kdepimlibs/kioslave/imap4/imap4.cpp:147
> 
> Useless "true &&".  
Fixed in imap4

Ciao,
Tobias
-- 
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institution!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080122/864798ee/attachment.sig>