Suspicous code in KDE 4 trunk r764353

[Ismail Dönmez]

Hi Christoph,

Tuesday 22 January 2008 01:21:42 tarihinde Christoph Bartoschek şunları 
yazmıştı:
> - kdebase/runtime/kioslave/sftp/process.cpp:429
>   kdebase/runtime/kioslave/sftp/process.cpp:423
>
> The condition < 0 is always false because ! results in 0 or 1.
>
>
> - kdebase/runtime/kioslave/sftp/process.cpp:207
>
> The file descriptor from line 191 is leaking here.

Looks like first two was porting error, the other one was a bug it seems. 
Thanks for checking KDE source once again.

Regards,
ismail


-- 
Never learn by your mistakes, if you do you may never dare to try again.