[PATCH] Phonon Gstreamer backend

[Andre Magalhaes]

On Jan 21, 2008 4:27 PM, Matthias Kretz <kretz at kde.org> wrote:
> On Monday 21 January 2008, Andre Magalhaes wrote:
> > On Jan 21, 2008 3:04 PM, Matthias Kretz <kretz at kde.org> wrote:
> > > The kde4_phonon_kdepluginfactory.cpp looks good, but I'd like to avoid
> > > the makeLibName function. One way to achieve that would be a, IMHO, sane
> > > QPluginLoader which does the correct thing itself. Brad, after our last
> > > chat about QPluginLoader, will Qt4.4 be able to just take a library name
> > > without lib prefix and without extension like QLibrary does?
> > >
> > > If it won't work in Qt 4.4 (or if we need to stay compatible with 4.3) I
> > > suggest to use
> > > cData.dirs()->findAllResources("module", newService->library +
> > > QLatin1String(".\*"));
> > > And then iterate over those to find one that works (like it does in
> > > factory.cpp).
> >
> > Done. New patch attached. I believe we should still be compatible with 4.3,
> > at least for now.
>
> Thanks a lot. A minor nitpick:
> foreach (QString libFile, modulePathList)
> should be
> foreach (const QString &libFile, modulePathList)
>
> I'll do that change. You don't need to send another patch.
Great, are you going to commit all the patches? Or should I commit?

BR

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko at gmail.com
MSN:   andremoreira at msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com