[PATCH] Phonon Gstreamer backend

Matthias Kretz kretz at kde.org
Mon Jan 21 19:27:34 GMT 2008

On Monday 21 January 2008, Andre Magalhaes wrote:
> On Jan 21, 2008 3:04 PM, Matthias Kretz <kretz at kde.org> wrote:
> > The kde4_phonon_kdepluginfactory.cpp looks good, but I'd like to avoid
> > the makeLibName function. One way to achieve that would be a, IMHO, sane
> > QPluginLoader which does the correct thing itself. Brad, after our last
> > chat about QPluginLoader, will Qt4.4 be able to just take a library name
> > without lib prefix and without extension like QLibrary does?
> >
> > If it won't work in Qt 4.4 (or if we need to stay compatible with 4.3) I
> > suggest to use
> > cData.dirs()->findAllResources("module", newService->library +
> > QLatin1String(".\*"));
> > And then iterate over those to find one that works (like it does in
> > factory.cpp).
> Done. New patch attached. I believe we should still be compatible with 4.3,
> at least for now.

Thanks a lot. A minor nitpick:
foreach (QString libFile, modulePathList)
should be
foreach (const QString &libFile, modulePathList)

I'll do that change. You don't need to send another patch.

Matthias Kretz (Germany)                            <><
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080121/405557f8/attachment.sig>

More information about the kde-core-devel mailing list