[PATCH] Phonon Gstreamer backend

Thiago Macieira thiago at kde.org
Fri Jan 18 16:05:26 GMT 2008

Andre Magalhaes wrote:
>On Jan 18, 2008 11:16 AM, Thiago Macieira <thiago at kde.org> wrote:
>> Andre Magalhaes wrote:
>> >Attached there is an updated patch that works with the latest svn
>> > (763074). I would like to commit it, what do you think?
>> Can you do it without reindenting everything?
>> I can't read the patch.
>Sure I can do it, but I think the code needs a reindent. Some files
>are indent the classes definition, other not, some are using #ifndef
>FILE_H others are using #ifndef Phonon_GSTREAMER_FILE_H. I tried to
>standardize the code, to make it easier to read.

Do that in a separate patch that does only that.

>What the patch does:
> - Add #include <phonon/phonon_export.h> to common.h and #include
>"common.h" to all header files.

Why not #include <phonon/phonon_export.h> instead?

There was only one header that missed it.

> - Include local headers first (#include "" first then #include <>)

Unnecessary change, but ok. Do it in a separate patch.

> - change all #ifndef FILE_H in the header files to #ifndef

Good point, but separate patch.

> - Do not indent classes definition inside namespaces (almost all
>files were correct)

Don't do that.

> - Install phonon_gstreamer.desktop
> - Proper export the plugin factory

Good point, but make that a third patch.

  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080118/f3f8f420/attachment.sig>

More information about the kde-core-devel mailing list