[PATCH] Phonon Gstreamer backend

Andre Magalhaes andrunko at gmail.com
Fri Jan 18 14:27:07 GMT 2008

On Jan 18, 2008 11:16 AM, Thiago Macieira <thiago at kde.org> wrote:
> Andre Magalhaes wrote:
> >Attached there is an updated patch that works with the latest svn
> > (763074). I would like to commit it, what do you think?
> Can you do it without reindenting everything?
> I can't read the patch.
Sure I can do it, but I think the code needs a reindent. Some files
are indent the classes definition, other not, some are using #ifndef
FILE_H others are using #ifndef Phonon_GSTREAMER_FILE_H. I tried to
standardize the code, to make it easier to read.

What the patch does:
 - Add #include <phonon/phonon_export.h> to common.h and #include
"common.h" to all header files.
 - Include local headers first (#include "" first then #include <>)
 - change all #ifndef FILE_H in the header files to #ifndef
 - Do not indent classes definition inside namespaces (almost all
files were correct)
 - Install phonon_gstreamer.desktop
 - Proper export the plugin factory

But if you still want I can provide a new patch


Andre Moreira Magalhaes (andrunko)
Jabber: andrunko at gmail.com
MSN:   andremoreira at msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com

More information about the kde-core-devel mailing list