untranslated entries in ksycoca (Re: Tagging Freeze for KDE 4.0.0)

[David Faure]

On Sunday 06 January 2008, kde.braxton at gmail.com wrote:
> On 1/4/08, Will Stephenson <wstephenson at kde.org> wrote:
> > On Friday 04 January 2008 17:27:21 kde.braxton at gmail.com wrote:
> > > On 1/4/08, Thomas Reitelbach <tr at erdfunkstelle.de> wrote:
> > > > Am Freitag, 4. Januar 2008 16:33:48 schrieb kde.braxton at gmail.com:
> > > > > On 1/4/08, Thomas Reitelbach <tr at erdfunkstelle.de> wrote:
> > > > > > Am Freitag, 4. Januar 2008 13:05:44 schrieb Albert Astals Cid:
> > > > > > > I completely disagree here, X-KDE-PluginInfo-Category is clearly
> > > > > > > defined
> > > > > >
> > > > > > as
> > > > > >
> > > > > > > translatable in ~/l10n-kde4/scripts/createdesktopcontext.pl so
> > it's
> > > > > > > your problem asuming a field would not be translated when it is.
> > > > > >
> > > > > > No, Albert, it was me who added the field in this file above.
> > > > > > I did it with translation in mind because it was needed in a
> > specific
> > > > > > place (plasmoid chooser), but I had no idea that it could cause any
> > > > > > problems.
> > > > >
> > > > > then KPluginInfo should use readEntryUntranslated instead of readEntry
> > > > > and it will ignore any translations.
> > > >
> > > > If this is a possible solution, then someone should implement it after
> > > > the release (IMO). We (translators) need to be able to translate those
> > > > category names, or they should be ermoved from GUI at all :-)
> > >
> > > as soon as the branch is reopened, I'll commit
> >
> > Careful.  What about KPluginInfo constructed from KService::Ptr?  IIUC the
> > KService will come from sycoca, which only contains the translated entries.
> >
> >
> > I considered looking up the desktop file again using
> > KPluginInfo::service()->desktopEntryPath() and then readEntryUntranslated()
> > too but this undoes the performance benefit of having sycoca since
> > kpluginselector will have to load eg 27 desktop files for KWin.
> 
> what if we increment the version number on sycoca? wouldn't that cause
> it to recreate the db the first time that it was accessed? if yes,
> then I could add both translated/untranslated entries. now my only
> problem is, where do I need to change to add the translated and
> untranslated entries to sycoca?

KService::init() I guess (see the end of the method, where we iterate over entryMap
and feed m_mapProps). 
init() is where desktop files are read, and they are serialized into ksycoca in the save() method.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).