[PATCH] Fix menu item widths in KStyle-based styles

Chusslove Illich caslav.ilic at gmx.net
Sun Jan 13 16:38:34 GMT 2008

> [: Maksim Orlovich :]
> How about the attached alternative? There is no reason to not add the
> margin, is there?
> [...]
>   widgetLayoutProp(WT_MenuItem, MenuItem::AccelSpace, option, widget)

In case the item has no accelerator and none is auto-assigned, there is no
gap at all between the longest item and its shortcut. I noticed it in my
Cyrillic-localized setup. Even when there is an accelerator, the shortcut is
still somehow too near to the item.

Also, just above these lines, when computing the width of the item without
shortcut, no extra margin is added. In the same no-acclerator case, this
causes that if the longest item has no shortcut, and say the item below has
a shortcut, that shortcut and the item above "touch corners".

How about unconditionally adding one fm.width('M') to textW after the
if/else? :)

Chusslove Illich (Часлав Илић)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080113/55239801/attachment.sig>

More information about the kde-core-devel mailing list