changing the parent of a KConfigGroup

kde.braxton at gmail.com kde.braxton at gmail.com
Wed Jan 2 15:07:23 GMT 2008


On 1/2/08, Matt Rogers <mattr at kde.org> wrote:
> On Wednesday 02 January 2008 01:11:57 Aaron J. Seigo wrote:
> > On Tuesday 01 January 2008, kde.braxton at gmail.com wrote:
> > > ok, this is just a quick try. it removes the caveat about reparenting
> > > to a different file, and actually copies the entries in the entryMap.
> > > it needs a test or two to make  sure it's doing what it's supposed to
> > > do.
> >
> > cool; i actually had to hack in what copyTo does to fix another issue just
> > today. of course, since i had to do it using the public API it's not
> great.
> > so i'd love to see this all go in if it does indeed work properly which,
> on
> > first read anyways, it seems to.
>
> there are unit tests for kconfig already in kdecore/tests. You could add
> more
> tests and then know for sure. :)
Ok, this is a new version with tests. It works, but I get the feeling
that it should probably have more tests because I'm not sure how it'll
act in situations other than specifically what I test.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reparent2.diff
Type: text/x-diff
Size: 7096 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080102/2d7d1759/attachment.diff>


More information about the kde-core-devel mailing list