KFadeWidgetEffect bugfix

Rafael Fernández López ereslibre at kde.org
Thu Feb 21 14:55:16 GMT 2008


> Please keep the comma where it was (I would've liked to specify that in the
> coding style guidelines, but for brevity it was omitted).

Yup, have no problem with that.

> Did you notice the Q_ASSERT a few lines down? If destWidget were 0 it would
> abort() (in a debug build). There must be a different problem you're
> looking for.

If you run systemsettings, is not about not having a parentWidget(), is about 
it _has_ a parentWidget, but when the kcm's are being loaded you see all 
titles on the left top corner of the window, what is pretty ugly.

As the widget developer user, I'd like to know who the parent is, maybe

MyWidget(QWidget *parent)
	: QWidget(parent->parent());

I really think is better to do it as the patch does:

MyWidget(QWidget *parent)
	: QWidget(parent)

> Uhm, what if this deleteLater gets carried out before start() gets called?
> Better move the deleteLater into start().
> >  }
> >  
> >  KFadeWidgetEffect::~KFadeWidgetEffect()


Patch attached. Matthias is this OK to commit ?

Rafael Fernández López

GPG Fingerprint: B9F4 4730 43F8 FFDD CC5E BA8E 724E 406E 3F01 D070
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfadewidgeteffect.diff
Type: text/x-diff
Size: 1283 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080221/4a023b9c/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080221/4a023b9c/attachment.sig>

More information about the kde-core-devel mailing list