[PATCH] Animations enable/disable system wide

Aaron J. Seigo aseigo at kde.org
Fri Feb 15 19:48:43 GMT 2008

On Friday 15 February 2008, Rafael Fernández López wrote:
> Attached are the patches to kdelibs and kdebase.

missing {}s (even on one-liners) as per the kdelibs coding style:

+    if (!KGlobalSettings::animationsEnabled())
+        return NULL;

what's the intended purpose of KGlobalSettings::animationsEnabledDefault();? 
why does it need to be exposed separately from animationsEnabled()? all the 
use cases i can think of should just use animationsEnabledDefault, but you 
probably have some use cases that haven't occured to me yet. ...

Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080215/6e335658/attachment.sig>

More information about the kde-core-devel mailing list