[PATCH] Qt 4.4 - Fix alien widgets in Dolphin

Robert Knight robertknight at gmail.com
Fri Feb 15 18:20:21 GMT 2008


I have committed the Dolphin patch as revision #775396.  KIO fixes can
come later.


On 14/02/2008, Robert Knight <robertknight at gmail.com> wrote:
> Hi,
>  After the update to Qt 4.4 Dolphin was not benefiting from alien
>  (non-X11 window) widgets because of a call to QWidget::winId() on the
>  main view widgets inside KIO which forces the creation of a native X11
>  window.
>  This can be traced back to calls in Dolphin to
>  KDirLister::setMainWindow(widget) where 'widget' was the viewing area.
>   The attached patch replaces this with setMainWindow(topLevelWidget())
>  where needed.
>  Since the actual call to winId() happens deep inside KIO, perhaps it
>  would be better to put a fix there and only ever get winIds for
>  top-level widgets to prevent applications doing this accidentally.
>  Thoughts?
>  Regards,
> Robert.

More information about the kde-core-devel mailing list