[PATCH] Qt 4.4 - Fix alien widgets in Dolphin

Robert Knight robertknight at gmail.com
Thu Feb 14 21:27:25 GMT 2008


After the update to Qt 4.4 Dolphin was not benefiting from alien
(non-X11 window) widgets because of a call to QWidget::winId() on the
main view widgets inside KIO which forces the creation of a native X11

This can be traced back to calls in Dolphin to
KDirLister::setMainWindow(widget) where 'widget' was the viewing area.
 The attached patch replaces this with setMainWindow(topLevelWidget())
where needed.

Since the actual call to winId() happens deep inside KIO, perhaps it
would be better to put a fix there and only ever get winIds for
top-level widgets to prevent applications doing this accidentally.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dolphin_fix_alien_view_widgets.patch
Type: text/x-patch
Size: 1637 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080214/d37610c3/attachment.bin>

More information about the kde-core-devel mailing list