KFadeWidgetEffect bugfix

Rafael Fernández López ereslibre at kde.org
Thu Feb 14 21:24:49 GMT 2008

Hi all,

After Urs applied this class usage to our KTitleWidgets (you can see that when 
our configuration dialogs if you change between pages, those titles are 
blended), I noticed that when the dialog is being loaded at a first time, 
those seem to have no parent, and thus being flying on the topleft corner of 
the dialog.

I considered this ugly enough to check the code ;), and I just saw the fade 
widget can be happily with no parent when being built, what causes this.

The attached patch fixes this solution. Sorry for the dirty patch, I just have 
lots of changes on kdelibs and I just can't separate them. The important bit 
of the patch is:

-    : QWidget(destWidget ? destWidget->parentWidget() : 0),
-    d_ptr(new KFadeWidgetEffectPrivate(destWidget))
+    : QWidget(destWidget)
+    , d_ptr(new KFadeWidgetEffectPrivate(destWidget))

When I commit all the animations stuff, is this OK to commit ?

Rafael Fernández López

GPG Fingerprint: B9F4 4730 43F8 FFDD CC5E BA8E 724E 406E 3F01 D070
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfadewidgeteffect.diff
Type: text/x-diff
Size: 1253 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080214/03960c8a/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080214/03960c8a/attachment.sig>

More information about the kde-core-devel mailing list