luna in kdereview, proposed move into extragear

[Torsten Rahn]

Wait 2 or 3 weeks and I have set up everything properly so that you can have 
Marble display the moon (and all kinds of planets that are close to being 
spheres (that excludes just Jupiter and Saturn).

Torsten


On Wednesday 13 February 2008 18:06:33 Aaron J. Seigo wrote:
> On Wednesday 13 February 2008, Davide Bettio wrote:
> > I just moved luna plasma applet to kdereview.
>
> great =) i see you put it in kdreview/ itself; i've moved it into
> kdreview/plasma/applets with the other applets under review.
>
> comments:
>
> * you could connect to the UTC data source of the Time DataEngine and avoid
> updateStatus() altogether. you get both the time and the date there, and
> QDateTime provides a toTime_t.
>
> * where is it actually updating the contents? i don't see anything
> connected to updateStatus(), and connectToEngine() isn't called anywhere?
> replace the call to updateStatus() in init() with a call to connectToEngine
> and things are happy (just tried)
>
> * i wonder if the painting might look better at different if the moon
> images were a bit bigger in the svg itself and you called
> m_theme->resize(contentSize()) in constraintsUpdated when the
> SizeConstraint is passed in
>
> * you shouldn't need to call updateGeometry in constraintsUpdated (if you
> do, there's a bug somewhere in libplasma =)
>
> * you don't need that contentSizeHint there, or expandingDirections. just
> call setRemainSquare(true) somewhere (e.g. the constructor of your applet)
>
> see attached patch.
>
> > Luna is a plasma applet based on the legacy kicker applet kmoon.
> > I hope that the applet can be moved to extragear/plasma/applets/ after
> > the
>
> that looks like a good place for it.



-- 
 Torsten Rahn

 Tel.: 0 21 61 - 46 43 - 192

credativ GmbH, HRB Mönchengladbach 12080
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz