[PATCH] KHTML Fix scrollbar positions

Roman Jarosz roman.jarosz at gmail.com
Thu Feb 7 12:21:51 GMT 2008


I have test it with Konqueror and I think we shouldn't clear the contentsX and contentsY
because otherwise Konqueror won't remember contents position on reload and also painting
won't be smooth.

Can I commit?

On Wed, 06 Feb 2008 23:53:16 +0100, Roman Jarosz <R.Jarosz at sh.cvut.cz> wrote:

> Hi,
>
> I found a problem with incorrect scrollbars in KHTML.
>
> When we call KHTMLPart::begin in KHTMLPart that already has some contents and scrollbars
> aren't at position 0 then clear() is called which sets contentsX and contentsY to 0 however
> the scrollbars remain at old positions. So the contents is painted at offset 0,0
> but the scrollbars are at old positions. (This happens in Kopete)
>
> This patch sets also scrollbars to position 0.
>
> I would commit it without asking but this behavior is different from KDE3.
> In KDE3 the position isn't cleared. So do we want to clear the scrollbar positions or should
> we instead remove the contentsX and contentsY clearing so the position is remembered?
>
> Thanks,
> Roman Jarosz


-------------- next part --------------
A non-text attachment was scrubbed...
Name: keepoffset.diff
Type: application/octet-stream
Size: 364 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080207/ebc32d17/attachment.obj>


More information about the kde-core-devel mailing list