kdereview exemption for PolicyKit-KDE

Dario Freddi drf54321 at gmail.com
Wed Dec 10 23:17:18 GMT 2008


On Wednesday 10 December 2008 19:18:25 Albert Astals Cid wrote:

>
> Some more things i saw at first sight:
>
> Function parameters are missing a lost const & like
>  void AuthDialog::setRequest(QString request, bool requiresAdmin)
> that should be
>  void AuthDialog::setRequest(const QString &request, bool requiresAdmin)
>
>
> You are using left() on strings
>  request.left(9).compare("password:", Qt::CaseInsensitive) == 0
> please use startsWith
>
>
> The kcm was totally untranslated because it was not loading the correct
> catalog name (fixed it)
>
> I'll have a deeper look if i have more time.

I'm fixing all krazy issues tonight

Dario

>
> Albert





More information about the kde-core-devel mailing list