kdereview exemption for PolicyKit-KDE

Albert Astals Cid aacid at kde.org
Wed Dec 10 18:18:25 GMT 2008

A Dimecres 10 Desembre 2008, Aaron J. Seigo va escriure:
> On Monday 08 December 2008, Thiago Macieira wrote:
> > Dario Freddi wrote:
> > >If nobody is against this, I would like to move it to kdereview now so
> > > that it can get more attention for anyone who wants to review it, since
> > > it is now stable and whatever its destiny will be it does no longer
> > > belong to playground. If I don't get any negative feedback I will move
> > > it to kdereview by tomorrow.
> >
> > That's fine.
> >
> > But please remember that you can't move it to trunk/KDE until the freeze
> > is lifted, in about a month.
> Dirk had proposed that this go into kdereview and be included in beta2 if
> it passed muster there. is that still a go or is that no longer on the
> table?
> (given that our downstreams will end up shipping it anyways, i hope that's
> still on the table.)

Some more things i saw at first sight:

Function parameters are missing a lost const & like
 void AuthDialog::setRequest(QString request, bool requiresAdmin)
that should be
 void AuthDialog::setRequest(const QString &request, bool requiresAdmin)

You are using left() on strings
 request.left(9).compare("password:", Qt::CaseInsensitive) == 0
please use startsWith

The kcm was totally untranslated because it was not loading the correct 
catalog name (fixed it)

I'll have a deeper look if i have more time.


More information about the kde-core-devel mailing list