KDE/kdelibs/kate/dialogs

[Anders Lund]

On Lørdag 06 december 2008, Nickolai Shaforostoff wrote:
> SVN commit 893646 by shaforo:
>
> use 0 bottim margins and 4px spacing to get smaller height for the whole
> kwrite/kate config dialog. this makes it usable on netbooks
>
>
>
>  M  +42 -9     schemaconfigcolortab.ui
>
>
> --- trunk/KDE/kdelibs/kate/dialogs/schemaconfigcolortab.ui #893645:893646
> @@ -6,16 +6,25 @@
>      <x>0</x>
>      <y>0</y>
>      <width>400</width>
> -    <height>300</height>
> +    <height>367</height>
>     </rect>
>    </property>
>    <layout class="QVBoxLayout" >
> -   <property name="margin" >
> -    <number>9</number>
> -   </property>
>     <property name="spacing" >
>      <number>6</number>
>     </property>
> +   <property name="leftMargin" >
> +    <number>9</number>
> +   </property>
> +   <property name="topMargin" >
> +    <number>9</number>
> +   </property>
> +   <property name="rightMargin" >
> +    <number>9</number>
> +   </property>
> +   <property name="bottomMargin" >
> +    <number>0</number>
> +   </property>
>     <item>
>      <widget class="QGroupBox" name="groupBox" >
>       <property name="title" >
> @@ -25,12 +34,24 @@
>        <bool>true</bool>
>       </property>
>       <layout class="QGridLayout" >
> -      <property name="margin" >
> +      <property name="leftMargin" >
>         <number>9</number>
>        </property>
> -      <property name="spacing" >
> +      <property name="topMargin" >
> +       <number>9</number>
> +      </property>
> +      <property name="rightMargin" >
> +       <number>0</number>
> +      </property>
> +      <property name="bottomMargin" >
> +       <number>9</number>
> +      </property>
> +      <property name="horizontalSpacing" >
>         <number>6</number>
>        </property>
> +      <property name="verticalSpacing" >
> +       <number>4</number>
> +      </property>
>        <item row="3" column="1" >
>         <widget class="KColorButton" name="markers" >
>          <property name="whatsThis" >
> @@ -99,12 +120,24 @@
>        <bool>true</bool>
>       </property>
>       <layout class="QGridLayout" >
> -      <property name="margin" >
> +      <property name="leftMargin" >
>         <number>9</number>
>        </property>
> -      <property name="spacing" >
> +      <property name="topMargin" >
> +       <number>9</number>
> +      </property>
> +      <property name="rightMargin" >
> +       <number>0</number>
> +      </property>
> +      <property name="bottomMargin" >
> +       <number>0</number>
> +      </property>
> +      <property name="horizontalSpacing" >
>         <number>6</number>
>        </property>
> +      <property name="verticalSpacing" >
> +       <number>4</number>
> +      </property>
>        <item row="4" column="1" >
>         <widget class="KColorButton" name="tmarker" >
>          <property name="whatsThis" >
> @@ -179,7 +212,7 @@
>       <property name="orientation" >
>        <enum>Qt::Vertical</enum>
>       </property>
> -     <property name="sizeHint" >
> +     <property name="sizeHint" stdset="0" >
>        <size>
>         <width>20</width>
>         <height>40</height>

I repeat that I think this is a very bad idea. I think it should be reverted, 
and thus I CC our maintainer.

If you are unhappy with the design of Kate dialogs, please write the mailing 
list and let us discuss if we can find a solution, or even file a bug report.

Kate is a KDE application, and we follow KDE standards, including using 
KDialog::spacingHint() etc.

We could discuss changing the dialog page(s) to make it fit small devices, 
although I believe that is a general discussion that affects more KDE 
applications than Kate. I recently tested a KDE application (KColorEdit) that 
does not fit in my 1440x900 laptop screen.

Also there are a lot of things that can affect this, such as style and font 
settings.

I think this discussion belongs in kde-usability or kde-core.

Finally, the change only affects one of many dialog pages, which makes the 
dialog internally inconsistent, apart from making it differ from KDE 
standards.

-- 
Anders

www: http://www.alweb.dk
jabber: anderslund at jabber.dk