include the svn revision in the --version info (wish 162179)
Jordi Polo
mumismo at gmail.com
Tue Dec 2 11:49:33 GMT 2008
Looks like a good solution.
Also, it seems that several of those are a little bit suspicious. Why kjots
need it? Surely is recreating something already done in the libraries.
On Tue, Dec 2, 2008 at 7:49 PM, Jaime <jtamate at gmail.com> wrote:
> That is why I have the following patch (my previous attempt did not reached
> the list :-( )
>
> I do not know why kdeversion.h (which changes every 2 weeks)
> is included in kapplication.h (included in around 1000 files)
> instead of kapplication.cpp (and a few others).
>
>
> --- kdelibs/kdeui/kernel/kapplication.h 2008-10-30 17:47:24.000000000
> +0100
> +++ kdelibs/kdeui/kernel/kapplication.h 2008-10-29 15:48:20.000000000 +0100
> @@ -22,7 +22,7 @@
> #define KAPP_H
>
> - // Version macros. Never put this further down.
> -#include "kdeversion.h"
> #include <kdeui_export.h>
>
> class KConfig;
>
> --- kdelibs/kdeui/kernel/kapplication.cpp 2008-10-30 17:52:52.000000000
> +0100
> +++ kdelibs/kdeui/kernel/kapplication.cpp 2008-10-29
> 15:54:11.000000000 +0100
> @@ -19,6 +19,7 @@
> */
>
> #undef QT_NO_TRANSLATION
> + // Version macros. Never put this further down.
> +#include "kdeversion.h"
> #include "kapplication.h"
> #define QT_NO_TRANSLATION
>
> --- kdelibs/kdeui/dialogs/kaboutapplicationdialog.cpp 2008-10-29
> 15:52:16.000000000 +0100
> +++ kdelibs/kdeui/dialogs/kaboutapplicationdialog.cpp 2008-11-04
> 10:36:56.000000000 +0100
> @@ -20,7 +20,6 @@
> Boston, MA 02110-1301, USA.
> */
>
> +#include "kdeversion.h"
> #include "kaboutapplicationdialog.h"
>
> #include <QLabel>
>
> --- kdelibs/kimgio/eps.cpp 2008-11-04 10:52:50.000000000 +0100
> +++ kdelibs/kimgio/eps.cpp 2008-10-29 16:58:12.000000000 +0100
> @@ -15,6 +15,7 @@
> #include <QtCore/QTemporaryFile>
> #include <kapplication.h>
> #include <kdebug.h>
> +#include <kdeversion.h>
>
> #define BUFLEN 200
>
> --- kdebase/runtime/khelpcenter/application.cpp 2008-11-04
> 11:26:08.000000000 +0100
> +++ kdebase/runtime/khelpcenter/application.cpp 2008-10-30
> 09:40:34.000000000 +0100
> @@ -22,6 +22,7 @@
> #include "mainwindow.h"
> #include "version.h"
>
> +#include <kdeversion.h>
> #include <kcmdlineargs.h>
> #include <kaboutdata.h>
> #include <klocale.h>
>
> --- kdebase/runtime/khelpcenter/khc_indexbuilder.cpp 2008-11-04
> 13:06:40.000000000 +0100
> +++ kdebase/runtime/khelpcenter/khc_indexbuilder.cpp 2008-10-30
> 09:44:09.000000000 +0100
> @@ -23,6 +23,7 @@
>
> #include "version.h"
>
> +#include <kdeversion.h>
> #include <kaboutdata.h>
> #include <klocale.h>
> #include <kcmdlineargs.h>
>
> --- kdebase/runtime/kioslave/trash/ktrash.cpp 2008-11-04 13:10:14.000000000
> +0100
> +++ kdebase/runtime/kioslave/trash/ktrash.cpp 2008-10-30
> 09:47:37.000000000 +0100
> @@ -17,6 +17,7 @@
> Boston, MA 02110-1301, USA.
> */
>
> +#include <kdeversion.h>
> #include <kapplication.h>
> #include <kio/netaccess.h>
> #include <kio/job.h>
>
> --- kdebase/runtime/kioslave/desktop/kio_desktop.cpp 2008-11-04
> 13:11:48.000000000 +0100
> +++ kdebase/runtime/kioslave/desktop/kio_desktop.cpp 2008-10-30
> 09:51:28.000000000 +0100
> @@ -19,6 +19,7 @@
>
> #include "kio_desktop.h"
>
> +#include <kdeversion.h>
> #include <KApplication>
> #include <KCmdLineArgs>
> #include <KConfigGroup>
>
> --- kdebase/apps/kinfocenter/main.cpp 2008-11-04 13:15:38.000000000 +0100
> +++ kdebase/apps/kinfocenter/main.cpp 2008-10-30 10:34:19.000000000 +0100
> @@ -35,6 +35,7 @@
> #include "toplevel.h"
> #include "global.h"
>
> +#include <kdeversion.h>
> #include <kcmdlineargs.h>
> #include <kaboutdata.h>
> #include <kglobalsettings.h>
>
> --- kdegames/ksirk/ksirk/GameLogic/gameautomaton.cpp 2008-11-04
> 13:18:08.000000000 +0100
> +++ kdegames/ksirk/ksirk/GameLogic/gameautomaton.cpp 2008-10-30
> 13:29:00.000000000 +0100
> @@ -39,6 +39,7 @@
> #include <QMouseEvent>
> #include <QFile>
>
> +#include <kdeversion.h>
> #include <klocale.h>
> #include <kdialog.h>
> #include <kinputdialog.h>
>
> --- kdegames/ksirk/ksirk/main.cpp 2008-11-04 13:19:40.000000000 +0100
> +++ kdegames/ksirk/ksirk/main.cpp 2008-10-30 13:33:11.000000000 +0100
> @@ -21,6 +21,7 @@
> #include "kgamewin.h"
> #include "GameLogic/gameautomaton.h"
>
> +#include <kdeversion.h>
> #include <kcmdlineargs.h>
> #include <kaboutdata.h>
> #include <klocale.h>
>
> --- kdegames/ksirk/ksirkskineditor/main.cpp 2008-11-04 13:25:22.000000000
> +0100
> +++ kdegames/ksirk/ksirkskineditor/main.cpp 2008-10-30
> 13:36:08.000000000 +0100
> @@ -25,6 +25,7 @@
>
> #include "mainwindow.h"
>
> +#include <kdeversion.h>
> #include <KCmdLineArgs>
> #include <KAboutData>
> #include <KLocale>
>
> --- kdenetwork/krdc/main.cpp 2008-11-04 13:28:10.000000000 +0100
> +++ kdenetwork/krdc/main.cpp 2008-10-31 09:41:26.000000000 +0100
> @@ -24,6 +24,7 @@
>
> #include "mainwindow.h"
>
> +#include <kdeversion.h>
> #include <KApplication>
> #include <KLocale>
> #include <KCmdLineArgs>
>
> --- kdepim/kjots/aboutdata.cpp 2008-11-04 13:29:28.000000000 +0100
> +++ kdepim/kjots/aboutdata.cpp 2008-10-31 09:43:03.000000000 +0100
> @@ -22,6 +22,7 @@
> without including the source code for Qt in the source distribution.
> */
>
> +#include <kdeversion.h>
> #include "aboutdata.h"
> #include <klocale.h>
> #include <libkdepim/pimapplication.h>
>
> --- kdeutils/kdessh/kdessh.cpp 2008-11-04 13:31:30.000000000 +0100
> +++ kdeutils/kdessh/kdessh.cpp 2008-10-31 09:43:55.000000000 +0100
> @@ -33,7 +33,7 @@
> #include <sys/time.h>
> #include <sys/resource.h>
>
>
> +#include <kdeversion.h>
> #include <KDebug>
> #include <KApplication>
> #include <KStandardDirs>
>
>
>
> 2008/12/2 David Faure <faure at kde.org>
>
> On Friday 21 November 2008, Alexander Neundorf wrote:
>> > This only runs if cmake runs. I.e. you can get a lot of updates via svn
>> up but
>> > as long as no cmake file is changed this doesn't run again, so you will
>> have
>> > a wrong svn revision.
>> > I wouldn't put it in as it is now.
>>
>> But as it is now it would recompile everything that includes kdeversion.h
>> when cmake runs (which is already often enough), while if this is updated
>> whenever svn up is done, then after _every single update_ we'll have to
>> recompile everything that includes kdeversion.h? That's deadly.
>> I'm against this, it would kill productivity.
>>
>> --
>> David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on
>> KDE,
>> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org
>> ).
>>
>
>
--
Jordi Polo Carres
NLP laboratory - NAIST
http://www.bahasara.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081202/61a637c9/attachment.htm>
More information about the kde-core-devel
mailing list