Looks like a good solution.<br>Also, it seems that several of those are a little bit suspicious. Why kjots need it? Surely is recreating something already done in the libraries. <br><br><br><br><div class="gmail_quote">On Tue, Dec 2, 2008 at 7:49 PM, Jaime <span dir="ltr"><<a href="mailto:jtamate@gmail.com">jtamate@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">That is why I have the following patch (my previous attempt did not reached the list :-( )<br>
<br> I do not know why kdeversion.h (which changes every 2 weeks)<br>
is included in kapplication.h (included in around 1000 files)<div><br>
instead of kapplication.cpp (and a few others).<br>
<br></div><br>--- kdelibs/kdeui/kernel/kapplication.h 2008-10-30 17:47:24.000000000 +0100<br>+++ kdelibs/kdeui/kernel/kapplication.h 2008-10-29 15:48:20.000000000 +0100<br>@@ -22,7 +22,7 @@<br> #define KAPP_H<br><br>
- // Version macros. Never put this further down.<br>-#include "kdeversion.h"<br> #include <kdeui_export.h><br><br> class KConfig;<br><br>--- kdelibs/kdeui/kernel/kapplication.cpp 2008-10-30 17:52:52.000000000 +0100<br>
+++ kdelibs/kdeui/kernel/kapplication.cpp 2008-10-29 15:54:11.000000000 +0100<br>@@ -19,6 +19,7 @@<br> */<br><br> #undef QT_NO_TRANSLATION<br>+ // Version macros. Never put this further down.<br>+#include "kdeversion.h"<br>
#include "kapplication.h"<br> #define QT_NO_TRANSLATION<br><br>--- kdelibs/kdeui/dialogs/kaboutapplicationdialog.cpp 2008-10-29 15:52:16.000000000 +0100<br>+++ kdelibs/kdeui/dialogs/kaboutapplicationdialog.cpp 2008-11-04 10:36:56.000000000 +0100<br>
@@ -20,7 +20,6 @@<br> Boston, MA 02110-1301, USA.<br> */<br><br>+#include "kdeversion.h"<br> #include "kaboutapplicationdialog.h"<br><br> #include <QLabel><br><br>--- kdelibs/kimgio/eps.cpp 2008-11-04 10:52:50.000000000 +0100<br>
+++ kdelibs/kimgio/eps.cpp 2008-10-29 16:58:12.000000000 +0100<br>@@ -15,6 +15,7 @@<br> #include <QtCore/QTemporaryFile><br> #include <kapplication.h><br> #include <kdebug.h><br>+#include <kdeversion.h><br>
<br> #define BUFLEN 200<br><br>--- kdebase/runtime/khelpcenter/application.cpp 2008-11-04 11:26:08.000000000 +0100<br>+++ kdebase/runtime/khelpcenter/application.cpp 2008-10-30 09:40:34.000000000 +0100<br>@@ -22,6 +22,7 @@<br>
#include "mainwindow.h"<br> #include "version.h"<br><br>+#include <kdeversion.h><br> #include <kcmdlineargs.h><br> #include <kaboutdata.h><br> #include <klocale.h><br><br>--- kdebase/runtime/khelpcenter/khc_indexbuilder.cpp 2008-11-04 13:06:40.000000000 +0100<br>
+++ kdebase/runtime/khelpcenter/khc_indexbuilder.cpp 2008-10-30 09:44:09.000000000 +0100<br>@@ -23,6 +23,7 @@<br><br> #include "version.h"<br><br>+#include <kdeversion.h><br> #include <kaboutdata.h><br>
#include <klocale.h><br> #include <kcmdlineargs.h><br><br>--- kdebase/runtime/kioslave/trash/ktrash.cpp 2008-11-04 13:10:14.000000000 +0100<br>+++ kdebase/runtime/kioslave/trash/ktrash.cpp 2008-10-30 09:47:37.000000000 +0100<br>
@@ -17,6 +17,7 @@<br> Boston, MA 02110-1301, USA.<br> */<br><br>+#include <kdeversion.h><br> #include <kapplication.h><br> #include <kio/netaccess.h><br> #include <kio/job.h><br><br>--- kdebase/runtime/kioslave/desktop/kio_desktop.cpp 2008-11-04 13:11:48.000000000 +0100<br>
+++ kdebase/runtime/kioslave/desktop/kio_desktop.cpp 2008-10-30 09:51:28.000000000 +0100<br>@@ -19,6 +19,7 @@<br><br> #include "kio_desktop.h"<br><br>+#include <kdeversion.h><br> #include <KApplication><br>
#include <KCmdLineArgs><br> #include <KConfigGroup><br><br>--- kdebase/apps/kinfocenter/main.cpp 2008-11-04 13:15:38.000000000 +0100<br>+++ kdebase/apps/kinfocenter/main.cpp 2008-10-30 10:34:19.000000000 +0100<br>
@@ -35,6 +35,7 @@<br> #include "toplevel.h"<br> #include "global.h"<br><br>+#include <kdeversion.h><br> #include <kcmdlineargs.h><br> #include <kaboutdata.h><br> #include <kglobalsettings.h><br>
<br>--- kdegames/ksirk/ksirk/GameLogic/gameautomaton.cpp 2008-11-04 13:18:08.000000000 +0100<br>+++ kdegames/ksirk/ksirk/GameLogic/gameautomaton.cpp 2008-10-30 13:29:00.000000000 +0100<br>@@ -39,6 +39,7 @@<br> #include <QMouseEvent><br>
#include <QFile><br><br>+#include <kdeversion.h><br> #include <klocale.h><br> #include <kdialog.h><br> #include <kinputdialog.h><br><br>--- kdegames/ksirk/ksirk/main.cpp 2008-11-04 13:19:40.000000000 +0100<br>
+++ kdegames/ksirk/ksirk/main.cpp 2008-10-30 13:33:11.000000000 +0100<br>@@ -21,6 +21,7 @@<br> #include "kgamewin.h"<br> #include "GameLogic/gameautomaton.h"<br><br>+#include <kdeversion.h><br>
#include <kcmdlineargs.h><br> #include <kaboutdata.h><br> #include <klocale.h><br><br>--- kdegames/ksirk/ksirkskineditor/main.cpp 2008-11-04 13:25:22.000000000 +0100<br>+++ kdegames/ksirk/ksirkskineditor/main.cpp 2008-10-30 13:36:08.000000000 +0100<br>
@@ -25,6 +25,7 @@<br><br> #include "mainwindow.h"<br><br>+#include <kdeversion.h><br> #include <KCmdLineArgs><br> #include <KAboutData><br> #include <KLocale><br><br>--- kdenetwork/krdc/main.cpp 2008-11-04 13:28:10.000000000 +0100<br>
+++ kdenetwork/krdc/main.cpp 2008-10-31 09:41:26.000000000 +0100<br>@@ -24,6 +24,7 @@<br><br> #include "mainwindow.h"<br><br>+#include <kdeversion.h><br> #include <KApplication><br> #include <KLocale><br>
#include <KCmdLineArgs><br><br>--- kdepim/kjots/aboutdata.cpp 2008-11-04 13:29:28.000000000 +0100<br>+++ kdepim/kjots/aboutdata.cpp 2008-10-31 09:43:03.000000000 +0100<br>@@ -22,6 +22,7 @@<br> without including the source code for Qt in the source distribution.<br>
*/<br><br>+#include <kdeversion.h><br> #include "aboutdata.h"<br> #include <klocale.h><br> #include <libkdepim/pimapplication.h><br><br>--- kdeutils/kdessh/kdessh.cpp 2008-11-04 13:31:30.000000000 +0100<br>
+++ kdeutils/kdessh/kdessh.cpp 2008-10-31 09:43:55.000000000 +0100<br>@@ -33,7 +33,7 @@<br> #include <sys/time.h><br> #include <sys/resource.h><br><br><br>+#include <kdeversion.h><br> #include <KDebug><br>
#include <KApplication><br> #include <KStandardDirs><br><br><br><br><div class="gmail_quote">2008/12/2 David Faure <span dir="ltr"><<a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>></span><div>
<div></div><div class="Wj3C7c"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>On Friday 21 November 2008, Alexander Neundorf wrote:<br>
> This only runs if cmake runs. I.e. you can get a lot of updates via svn up but<br>
> as long as no cmake file is changed this doesn't run again, so you will have<br>
> a wrong svn revision.<br>
> I wouldn't put it in as it is now.<br>
<br>
</div>But as it is now it would recompile everything that includes kdeversion.h<br>
when cmake runs (which is already often enough), while if this is updated<br>
whenever svn up is done, then after _every single update_ we'll have to<br>
recompile everything that includes kdeversion.h? That's deadly.<br>
I'm against this, it would kill productivity.<br>
<font color="#888888"><br>
--<br>
David Faure, <a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>, sponsored by Qt Software @ Nokia to work on KDE,<br>
Konqueror (<a href="http://www.konqueror.org" target="_blank">http://www.konqueror.org</a>), and KOffice (<a href="http://www.koffice.org" target="_blank">http://www.koffice.org</a>).<br>
</font></blockquote></div></div></div><br>
</blockquote></div><br><br clear="all"><br>-- <br>Jordi Polo Carres<br>NLP laboratory - NAIST<br><a href="http://www.bahasara.org">http://www.bahasara.org</a><br><br>