[PATCH] Fix deref() in KMainWindow not being called

Rafael Fernández López ereslibre at kde.org
Fri Aug 1 19:18:33 BST 2008


Hi,

> Little update: As Rafael suggested, the deref() call is now the last call
> in the destructor, as it might trigger quitting the application.

I have applied this patch, and everything seems to work fine. In logic terms, 
this patch should work and also in logic terms the amount of ref/deref seems 
to be also balanced.

I'd say this patch is OK to commit, but I would love to see this patch 
reviewed by David before committing to trunk (consider to backport it to 4.1 
since I backported the previous patches about this issue too). David and me 
have been fighting with the ref/deref problems lately.


Regards,
Rafael Fernández López.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080801/42403562/attachment.sig>


More information about the kde-core-devel mailing list